[pulseaudio-discuss] [PATCH] Fix wrong input device in module-waveout

[Tanu Kaskinen]

On Thu, 2017-02-23 at 17:38 +0100, Moritz Bruder wrote:
> Both input and output device were chosen with the same device number.
> This is problematic as those numbers don't have to correspond.
> Additionally the input device was named after the output device. This
> commit adresses both issues by providing specific parameters for each
> type.
> ---
>  src/modules/module-waveout.c | 89 ++++++++++++++++++++++++++++++--------------
>  1 file changed, 62 insertions(+), 27 deletions(-)

Thanks for the patch! One comment below:

>  static const char* const valid_modargs[] = {
>      "sink_name",
>      "source_name",
> -    "device",
> -    "device_name",
> +    "output_device",
> +    "output_device_name",
> +    "input_device",
> +    "input_device_name",

Could we keep supporting the old "device" and "device_name" options to
keep compatibility with old configuration files? Or at least print a
helpful error message with instructions for how to update the
configuration if those options are passed?

-- 
Tanu

https://www.patreon.com/tanuk