[pulseaudio-discuss] [PATCH] bluez5-device: Log subband count instead of subband flag

[Tanu Kaskinen]

On Mon, 2017-06-19 at 16:47 +0300, Tanu Kaskinen wrote:
> On Mon, 2017-06-19 at 11:39 +0300, Luiz Augusto von Dentz wrote:
> > Hi Grzegorz,
> > 
> > On Mon, Jun 12, 2017 at 6:42 PM, Grzegorz Kolodziejczyk
> > <grzegorz.kolodziejczyk at codecoup.pl> wrote:
> > > As log information says, SBC log info have to have one of two subband count
> > > values: 4 or 8, instead of subband flag.
> > > ---
> > >  src/modules/bluetooth/module-bluez5-device.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c
> > > index 867def7..b86ec97 100644
> > > --- a/src/modules/bluetooth/module-bluez5-device.c
> > > +++ b/src/modules/bluetooth/module-bluez5-device.c
> > > @@ -1318,7 +1318,7 @@ static void transport_config(struct userdata *u) {
> > >          sbc_info->frame_length = sbc_get_frame_length(&sbc_info->sbc);
> > > 
> > >          pa_log_info("SBC parameters: allocation=%u, subbands=%u, blocks=%u, bitpool=%u",
> > > -                    sbc_info->sbc.allocation, sbc_info->sbc.subbands, sbc_info->sbc.blocks, sbc_info->sbc.bitpool);
> > > +                    sbc_info->sbc.allocation, sbc_info->sbc.subbands ? 8 : 4, sbc_info->sbc.blocks, sbc_info->sbc.bitpool);
> > >      }
> > >  }
> > > 
> > > --
> > > 2.9.4
> > 
> > LGTM, though Id like to see the bluez4 removal patches to be applied
> > first so this would need to be rebased after that.
> 
> If you resend the bluez4 removal patch with the module-bluetooth-policy 
> changes, I can then apply this patch too (and rebase it if that's
> needed).

It's been a while, and a v2 of the bluez4 removal patches hasn't
materialized. I applied this patch now to both "master" and "next".

-- 
Tanu

https://www.patreon.com/tanuk