[pulseaudio-discuss] Coverity scan

[Peter Meerwald-Stadler]

Hello,

> I’ve just disabled the weekly Jenkins/Coverity Scan builds of
> PulseAudio on jenkins.freedesktop.org to stop them continually
> recreating the pa_assert_se() issues in the report.

ok
what coverity version is installed on jenkins?
 
> I don’t have time to modify the definition of pa_assert_se() to fix
> this in upstream git at the moment. I’d love to re-enable the builds in
> Jenkins when someone does fix this though. Arun seemed to approve of
> them, at least.

can't we just stick
#nodef pa_assert_se(_unique_x) do { int _unique_y = _unique_x ; if (!_unique_y) __coverity_panic__(); } while (0)
into config/user_nodefs.h for now?

thanks, p.

> 
> On Wed, 2017-02-22 at 12:06 +0000, Philip Withnall wrote:
> > Hi,
> > 
> > On Wed, 2017-02-22 at 11:52 +0000, Philip Withnall wrote:
> > > Apologies if this has been discussed before (I don’t follow
> > > PulseAudio
> > > development), but why not stick this in the server-side Coverity
> > > modelling file? Does that not work?
> > 
> > Having just tried it, apparently it doesn’t work. I guess the
> > preprocessing is all done at cov-build time, and no information about
> > macros is sent up to the server for the modelling file to use.
> > 
> > > Failing that, there’s the __COVERITY__ macro which could be used to
> > > change the definition of pa_assert_se() in upstream git:
> > > https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/prevent-4.3.1/
> > > i3
> > > 86
> > > _linux26/opt/prevent-linux-4.3.1/doc/prevent_admin.html#N40430
> > 
> > So there’s still this to try.
> 
> ^-- This is the approach I think is worth trying.
> 
> Philip
> 
> > (Note: I’m not on the PulseAudio mailing list, so please include me
> > in
> > CC in replies.)

-- 

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418