[pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups

Hajime Fujita crisp.fujita at nifty.com
Thu Mar 9 03:25:33 UTC 2017


Hi Peter,

Thank you for the fix; raop patches look good to me.

Best,
Hajime

> On Mar 8, 2017, at 9:09 AM, Peter Meerwald-Stadler <pmeerw at pmeerw.net> wrote:
> 
> some more Coverity fixes and cleanups
> also addresses Hajime Fujita's earlier review comments
> 
> Peter Meerwald-Stadler (8):
>  raop: Fix potential dereference after NULL check
>  raop: Fix potential NULL dereference
>  raop: Log if pa_atoi() fails, latency is not used anyway
>  raop: Error out on parsing server port component
>  core: Assert return value of pa_shared_set/_remove() in dbus-shared
>  core: Document behaviour of pa_shared_remove() in case name does not
>    exist
>  oss: Fix dead code
>  pulse: Explicitly ignore pa_mainloop_run() return value in thread
>    function
> 
> src/modules/oss/module-oss.c   |  2 +-
> src/modules/raop/raop-client.c | 50 +++++++++++++++++++++++++-----------------
> src/modules/raop/raop-sink.c   | 10 +++++----
> src/pulse/thread-mainloop.c    |  2 +-
> src/pulsecore/dbus-shared.c    |  4 ++--
> src/pulsecore/shared.c         |  2 +-
> src/pulsecore/shared.h         |  4 +++-
> 7 files changed, 44 insertions(+), 30 deletions(-)
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss



More information about the pulseaudio-discuss mailing list