[pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

Tanu Kaskinen tanuk at iki.fi
Mon May 1 20:10:53 UTC 2017

On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote:
> There are several places in module-echo-cancel where a segfault is
> possible when the master sink or source is invalid.

I don't think the rewind, volume and mute callbacks are ever called
during stream moves, at least with the current code base. However,
adding the extra checks does no harm either, so I don't mind, but I
think the commit message should be clarified on this point.

> This patch checks for the validity of master source or sink and
> lets the functions just return if it is invalid.
> Other virtual sinks and sources will be fixed in a separate patch.

Squashing the two patches would seem appropriate to me.

The code changes in the other patch looked good to me (with the same
caveat that most of the changes are probably unnecessary).



More information about the pulseaudio-discuss mailing list