[pulseaudio-discuss] [PATCH v2] sink-input, source-output: don't allow moving streams that are connected to moving filter devices

[Tanu Kaskinen]

On Mon, 2017-05-08 at 12:58 +0300, Tanu Kaskinen wrote:
> When a filter sink is moving, it's not connected to any master sink, and
> therefore it's not connected to any IO thread either. In this situation
> trying to move a stream that is connected to the filter sink is likely
> to result in crashing, because starting the move involves sending a
> message to the IO thread. Sometimes this works by accident (the
> asyncmsgq of the filter sink still points to the old master sink's
> asyncmsgq), but we really should never attempt it. This patch blocks all
> moves where the moving stream is connected to a filter sink that itself
> is in the middle of a move.
> 
> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=100277
> ---
> 
> This is an old patch that was not applied on the first submission,
> because it was not necessary for fixing the bug at hand at that time.
> Here's the v1 (there are no changes in the code):
> https://patchwork.freedesktop.org/patch/68741/
> 
> Changes in v2:
>  - rewrote the commit message
> 
> 
>  src/pulsecore/sink-input.c    | 26 ++++++++++++++++++++++++++
>  src/pulsecore/source-output.c | 27 +++++++++++++++++++++++++++
>  2 files changed, 53 insertions(+)

I pushed this now.

-- 
Tanu

https://www.patreon.com/tanuk