[pulseaudio-discuss] [PATCH 0/2] module-echo-cancel fixes
Tanu Kaskinen
tanuk at iki.fi
Wed Nov 29 23:41:20 UTC 2017
On Thu, 2017-11-09 at 10:19 -0500, Raman Gupta wrote:
> On 09/11/17 07:12 AM, Tanu Kaskinen wrote:
> > Tanu Kaskinen (2):
> > echo-cancel: ignore remaining canceller messages after the module has
> > been unloaded
> > echo-cancel: fix a memory leak
> >
> > src/modules/echo-cancel/module-echo-cancel.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
>
> Tanu, is it possible to add unit tests that will help ensure this
> isn't broken again in the future? This is the second or third time
> I've had an issue related to this.
Reproducing your problems requires a running daemon with a specific
hardware configuration. If we had a module that simulated a card with
configurable profiles, a hardware-independent test could be written,
but we don't have that.
--
Tanu
https://www.patreon.com/tanuk
More information about the pulseaudio-discuss
mailing list