[pulseaudio-discuss] [PATCH 5/6] protocol-native: Add signal receiving capability

[Tanu Kaskinen]

On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote:
> --- a/src/pulsecore/native-common.h
> +++ b/src/pulsecore/native-common.h
> @@ -71,6 +71,7 @@ enum {
>      PA_COMMAND_GET_SAMPLE_INFO,
>      PA_COMMAND_GET_SAMPLE_INFO_LIST,
>      PA_COMMAND_SUBSCRIBE,
> +    PA_COMMAND_SUBSCRIBE_SIGNALS,
>  
>      PA_COMMAND_SET_SINK_VOLUME,
>      PA_COMMAND_SET_SINK_INPUT_VOLUME,

I didn't notice this in the first review, but somehow it came to my
mind to re-check this detail, and indeed, here's a bug: the new command
has to go to the end of the enumeration, because otherwise it will
change the numeric values of the enum items below it. That will cause
incompatibility between different versions of server and client.

-- 
Tanu

https://www.patreon.com/tanuk