[pulseaudio-discuss] [PATCH 6/6] pactl: Add signal receiver

[Tanu Kaskinen]

On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote:
> +    <option>
> +      <p><opt>subscribe-signals</opt></p>
> +      <optdesc><p>Subscribe to signals. Like subscribe, but waits for signals instead of subscription events.</p></optdesc>
> +    </option>

I think it would be better to have the "subscribe" command show both
kind of events.

> +static void context_signal_callback(pa_context *c, const char *sender, const char *signal, const char *signal_info, void *userdata) {
> +    pa_assert(c);
> +
> +    printf(_("Signal '%s' from %s\n"),
> +           signal,
> +           sender);
> +    if (signal_info)
> +        printf(_("Signal Info: '%s'\n"), signal_info);

We use the term "signal parameters" elsewhere (and I prefer that term),
so I'd like to use the same term here.

pulse/subscribe.[ch] seem to use the "signal info" term too, would you
mind changing them as well?

-- 
Tanu

https://www.patreon.com/tanuk