[pulseaudio-discuss] [PATCH] sink: remove priority bonus for the "internal" form factor

Tanu Kaskinen tanuk at iki.fi
Wed Sep 6 13:08:29 UTC 2017

We're supposed to prioritize USB sound cards over PCI sound cards, but
the priority bonus for the "internal" form factor prevents this from
happening. Not all (if any) USB sound cards have the form factor
property set, whereas at least on my laptop the on-board sound card has
the form factor set to "internal".

Maybe we should release 11.1 and include this fix. We advertised that
11.0 would start prioritizing USB over internal sound cards, so it's
embarrassing that it doesn't actually do that.

 src/pulsecore/sink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
index 0cc765144..52ad28bf5 100644
--- a/src/pulsecore/sink.c
+++ b/src/pulsecore/sink.c
@@ -3551,8 +3551,6 @@ unsigned pa_device_init_priority(pa_proplist *p) {
             priority += 500;
         else if (pa_streq(s, "portable"))
             priority += 450;
-        else if (pa_streq(s, "internal"))
-            priority += 400;
     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_BUS))) {

More information about the pulseaudio-discuss mailing list