[pulseaudio-discuss] [Patch] RAOP: fix audio synchronisation, take two

Colin Leroy colin at colino.net
Sun Sep 17 18:54:19 UTC 2017

On 17 September 2017 at 19h51, Tanu Kaskinen wrote:


> "git am" fails to apply the patch on top of the master branch (as it
> failed to apply the previous versions too, but I forgot to mention
> that earlier).

Sorry, I forgot to pull :) 

> The commit message could explain also why pa_smoother_reset() is used
> instead of pause()/resume().


> Why do you check the return value of pa_modargs_get_value() before
> calling pa_modargs_get_value_u32()? As far as I can tell, that makes
> no difference.

pa_modargs_get_value_u32() (and its friends) set the parameter to 0 if
it's not present, returning -1 only in case of integer conversion error.

> Nitpicking: the convention is to use the PA_USEC_PER_MSEC constant
> instead of bare "1000".

Fixed too :)

I attached an updated patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-RAOP-Announce-real-latency.patch
Type: text/x-patch
Size: 7713 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170917/7da357b4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170917/7da357b4/attachment.sig>

More information about the pulseaudio-discuss mailing list