[pulseaudio-discuss] [Patch] RAOP: fix audio synchronisation, take two

[Tanu Kaskinen]

On Tue, 2017-09-19 at 19:56 +0200, Colin Leroy wrote:
> On 18 September 2017 at 22h47, Tanu Kaskinen wrote:
> 
> Hi, 
> 
> > No, the function doesn't set the parameter when the argument is not
> > present.
> 
> Oh, right, I misread it. I could have initialized the argument to an
> arbitrary value and compare that after parsing, but that would be
> uglier.
> 
> > Since the function returns zero both when a valid value is provided
> > and when the argument is not set, you need to call
> > pa_modargs_get_value() in order to know whether to set the
> > latency_set flag or not, so it's not as useless as I first thought.
> 
> Indeed. Reworked that part a bit as I didn't need a temporary variable
> in fact.
> 
> > If the argument is set, but parsing it fails, you should log an error
> > message and fail. (Somehow it didn't occur to me to complain about
> > this earlier.)
> 
> Thanks, done. 

Thanks! Applied. I took the liberty to remove the
pa_modargs_get_value() from raop-sink.c, because it wasn't necessary
there.

-- 
Tanu

https://www.patreon.com/tanuk