[pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

Georg Chini georg at chini.tk
Sun Sep 24 13:07:50 UTC 2017


On 21.09.2017 21:26, James Bottomley wrote:
> The PA_BLUETOOTH_PROFILE names should mirror the PA_BLUETOOTH_UUID
> names using profile_function instead of randomly made up names.  Fix
> this with the transformation:
>
> PA_BLUETOOTH_PROFILE_HEADSET_HEAD_UNIT -> PA_BLUETOOTH_PROFILE_HSP_HS
> PA_BLUETOOTH_PROFILE_HEADSET_AUDIO_GATEWAY -> PA_BLUETOOTH_PROFILE_HFP_AG
>
> Signed-off-by: James Bottomley <James.Bottomley at HansenPartnership.com>
>
It looks to me like the conversion is not completely correct. In fact,
the native backend (in your notation) currently implements

PA_BLUETOOTH_PROFILE_HSP_HS
PA_BLUETOOTH_PROFILE_HSP_AG

while the ofono backend implements

PA_BLUETOOTH_PROFILE_HFP_HF
PA_BLUETOOTH_PROFILE_HFP_AG

Would it collide with your later patches to distinguish between the
different roles/profiles already in your first patch? As far as I can
see, the real separation of HSP/HFP is mainly done in the native
backend.

Regards
              Georg



More information about the pulseaudio-discuss mailing list