[pulseaudio-discuss] [PATCH v3 09/12] gsettings: remove bad signal connection

[Tanu Kaskinen]

The removed g_signal_connect() call didn't make sense. The callback
expects to be called when individual module groups are changed, not when
the top level object is changed. Also, module_group_callback() expects
user_data to be non-NULL, but here it was set to NULL.
---
 src/modules/gsettings/gsettings-helper.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/modules/gsettings/gsettings-helper.c b/src/modules/gsettings/gsettings-helper.c
index 3bd4b1bab..f000e85e5 100644
--- a/src/modules/gsettings/gsettings-helper.c
+++ b/src/modules/gsettings/gsettings-helper.c
@@ -90,8 +90,6 @@ int main(int argc, char *argv[]) {
     if (!(settings = g_settings_new(PA_GSETTINGS_MODULE_GROUPS_SCHEMA)))
         goto fail;
 
-    g_signal_connect(settings, "changed", (GCallback) module_group_callback, NULL);
-
     group_names = g_settings_list_children(settings);
 
     for (name = group_names; *name; name++) {
-- 
2.16.3