[pulseaudio-discuss] [PATCH v2 0/2] Bluetooth A2DP aptX codec support

[Tanu Kaskinen]

On Mon, 2018-08-06 at 13:52 +0300, Tanu Kaskinen wrote:
> On Mon, 2018-08-06 at 10:25 +0200, Pali Rohár wrote:
> > On Friday 03 August 2018 12:45:51 Tanu Kaskinen wrote:
> > > On Fri, 2018-08-03 at 10:33 +0200, Pali Rohár wrote:
> > > > On Saturday 28 July 2018 17:34:51 Pali Rohár wrote:
> > > > > This patch series moves A2DP codec code into new modules and add
> > > > > support for Bluetooth A2DP aptX codec.
> > > > > 
> > > > > Pali Rohár (2):
> > > > >   Modular API for Bluetooth A2DP codec
> > > > >   Bluetooth A2DP aptX codec support
> > > > > 
> > > > >  configure.ac                                 |  19 +
> > > > >  src/Makefile.am                              |  14 +-
> > > > >  src/modules/bluetooth/a2dp-codecs.h          | 123 +++++-
> > > > >  src/modules/bluetooth/bluez5-util.c          | 377 +++++++----------
> > > > >  src/modules/bluetooth/bluez5-util.h          |  12 +-
> > > > >  src/modules/bluetooth/module-bluez5-device.c | 542 ++++++++-----------------
> > > > >  src/modules/bluetooth/pa-a2dp-codec-aptx.c   | 297 ++++++++++++++
> > > > >  src/modules/bluetooth/pa-a2dp-codec-sbc.c    | 579 +++++++++++++++++++++++++++
> > > > >  src/modules/bluetooth/pa-a2dp-codec.h        |  41 ++
> > > > >  9 files changed, 1393 insertions(+), 611 deletions(-)
> > > > >  create mode 100644 src/modules/bluetooth/pa-a2dp-codec-aptx.c
> > > > >  create mode 100644 src/modules/bluetooth/pa-a2dp-codec-sbc.c
> > > > >  create mode 100644 src/modules/bluetooth/pa-a2dp-codec.h
> > > > 
> > > > Hello, can somebody review this patch series for aptX support?
> > > 
> > > Yes, eventually.
> > > 
> > > We're short on reviewer bandwidth - would you be interested in becoming
> > > a regular reviewer yourself to improve the situation?
> > 
> > Hi! I do not have time for reviewing all patches, nor I do not
> > understand pulseaudio such deeply. I played more with bluetooth
> > integration code, so I could help with reviewing bluetooth changes.
> 
> I certainly wasn't expecting you to review all patches - every little
> bit helps! If you have time to keep an eye on incoming patches and
> occasionally review some of them (concentrating on bluetooth patches is
> a fine approach for example), that would be awesome! You can set up
> email notifications in GitLab - see the drop-down menu with the bell
> icon on this page: https://gitlab.freedesktop.org/pulseaudio/pulseaudio
>  - You can "watch" the whole project, but if you want to get emails
> only  for new merge requests, choose "Custom" which allows you to pick
> only merge request related events.

Forgot to mention: if you choose to contribute this way, I'll be happy
to answer any questions in irc if you want to understand the code
better.

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk