[pulseaudio-discuss] [PATCH 0/8] *** Overview ***

Tanu Kaskinen tanuk at iki.fi
Sun Aug 12 12:24:42 UTC 2018


On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote:
> Module zeroconf-discover would add the same sink twice: once over IPv4, once
> over IPv6. Fixes:
> 
>  * Options to disable IPv4 and IPv6. If both options are provided, the module
>    fails to load.
>  * Option to only load one tunnel per avahi service name and type.
> 
> All the tunnel modules would immediately add a sink or source, even before
> authentication. Fix:
> 
>  * Add the sink/source only after the context is successfully connected.
> 
> And some additional fixes:
> 
>  * zeroconf-discover: fix memory leak and prevent double-free.
>  * pa_object_new: fix missing close paren.
> 
> 
> Yclept Nemo (8):
>   zeroconf-discover: add arguments to disable ipv4/6
>   zeroconf-discover: fix memory issues
>   zeroconf-discover: add argument 'one_per_name_type'
>   tunnel*: put sink/source after authentication
>   Fixes
>   tunnel*: redo 'put sink/source after auth..'
>   Fix pa_object_new macro (missing close paren)
>   zeroconf-discover: fix 'one_per_name_type'

Once I started to review patches 5 and 6, I found out that the later
patches undo a lot of things of the earlier patches. Please clean up
the commits before submitting your work, so that I get to review
finished patches instead of the trial-and-error development process.

Nevertheless, thanks for working on this!

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk


More information about the pulseaudio-discuss mailing list