[pulseaudio-discuss] [PATCH] improve reproducibility build

[Tanu Kaskinen]

(Hongxu Jia is not subscribed to the list, so I added him to Cc.)

On Thu, 2018-12-06 at 14:17 +0500, Alexander E. Patrakov wrote:
> Hongxu Jia <hongxu.jia at windriver.com>:
> > While running pulseaudio out of build dir (especially for cross
> > compiling), we should not expose pulseaudio build path[1], it is
> > helpful for reproducibility build[2].
> > 
> > As commit introduced [3cae4a0 doc: Add info about running pulseaudio
> > from the build dir], run pulseaudio from the build dir, __OPTIMIZE__
> > should be diabled, so add macro checking to drop PA_SRCDIR/PA_BUILDDIR
> > (in which contains build path) at precompilation.
> > 
> > [1] https://reproducible-builds.org/docs/build-path/
> > [2] https://reproducible-builds.org/
> > 
> > Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
> 
> I don't believe that the doc that you are basing your decisions on is
> correct. Anyway, basing such decisions automagically on the
> optimization level is very non-obvious. Maybe it is a better idea to
> introduce a special build flag (for autotools it would be something
> like --disable-running-from-build-tree or --enable-reproducible-build)
> that explicitly disables running from build tree and thus enables a
> reproducible build?

Yes, adding a configure option with an associated define is much more
clear and reliable than using __OPTIMIZE__. I think --disable-running-
from-build-tree would be better than --enable-reproducible-build,
because the latter promises that the build will be reproducible, while
in reality there are reproducibility issues that aren't (at least yet)
addressed (PA_CFLAGS definition is one example that can cause problems,
and I wouldn't be surprised if there were other things too).

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk