[pulseaudio-discuss] [PATCH v2] Add configurable RTP stream name

[Peter Meerwald-Stadler]

> Path add configuration option 'stream_name' for stream/session name
> So user will see it on receiver side as RTP Strean ($stream_name)

nitpick below
 
> ex: load-module module-rtp-send source=rtp.monitor stream_name=MyServerMedia
> ---
>  src/modules/rtp/module-rtp-send.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/src/modules/rtp/module-rtp-send.c b/src/modules/rtp/module-rtp-send.c
> index 61900c01..107907b7 100644
> --- a/src/modules/rtp/module-rtp-send.c
> +++ b/src/modules/rtp/module-rtp-send.c
> @@ -66,6 +66,7 @@ PA_MODULE_USAGE(
>          "loop=<loopback to local host?> "
>          "ttl=<ttl value> "
>          "inhibit_auto_suspend=<always|never|only_with_non_monitor_sources>"
> +        "stream_name=<name of the stream>"
>  );
> 
>  #define DEFAULT_PORT 46000
> @@ -90,6 +91,7 @@ static const char* const valid_modargs[] = {
>      "loop",
>      "ttl",
>      "inhibit_auto_suspend",
> +    "stream_name",
>      NULL
>  };
> 
> @@ -469,7 +471,10 @@ int pa__init(pa_module*m) {
>      k = sizeof(sa_dst);
>      pa_assert_se((r = getsockname(fd, (struct sockaddr*) &sa_dst, &k)) >= 0);
> 
> -    n = pa_sprintf_malloc("PulseAudio RTP Stream on %s", pa_get_fqdn(hn, sizeof(hn)));
> +    n = pa_xstrdup(pa_modargs_get_value(ma, "stream_name", NULL));
> +    if(n == NULL) {

please add a space after if, i.e
if (n == NULL)

> +        n = pa_sprintf_malloc("PulseAudio RTP Stream on %s", pa_get_fqdn(hn, sizeof(hn)));
> +    }
> 
>      if (af == AF_INET) {
>          p = pa_sdp_build(af,
> @@ -485,7 +490,7 @@ int pa__init(pa_module*m) {
>  #endif
>      }
> 
> -    pa_xfree(n);
> +    pa_xfree(n); /* safe for NULL */
> 
>      pa_rtp_context_init_send(&u->rtp_context, fd, m->core->cookie, payload, pa_frame_size(&ss));
>      pa_sap_context_init_send(&u->sap_context, sap_fd, p);
> --
> 2.18.0
> 
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> 

-- 

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418