[pulseaudio-discuss] [PATCH] alsa-mixer: make the mono mapping a fallback only

[Tanu Kaskinen]

On Fri, 2018-06-08 at 21:10 +0530, Arun Raghavan wrote:
> 
> On Fri, 8 Jun 2018, at 2:09 AM, Tanu Kaskinen wrote:
> > On Thu, 2018-06-07 at 17:17 +0200, Georg Chini wrote:
> > > On 01.06.2018 10:24, Tanu Kaskinen wrote:
> > > > If a sound card doesn't have the "front" device defined for it, we have
> > > > to use the "hw" device for stereo. Not so long ago, the analog-stereo
> > > > mapping had "hw:%f" in its device-strings and everything worked great,
> > > > except that it caused trouble with the Intel HDMI LPE driver that uses
> > > > the first "hw" device for HDMI, and we were incorrectly detecting it as
> > > > an analog device. That problem was fixed in commit ea3ebd09, which
> > > > removed "hw:%f" from analog-stereo and added a new stereo fallback
> > > > mapping for "hw".
> > > > 
> > > > Now the problem is that if a sound card doesn't have the "front" device
> > > > defined for it, and it supports both mono and stereo, only the mono
> > > > mapping is used, because the stereo mapping is only a fallback. This
> > > > patch makes the mono mapping a fallback too, so the mono mapping is used
> > > > only if there's absolutely nothing else that works.
> > > > 
> > > > This can cause trouble at least in theory. Maybe someone actually wants
> > > > to use mono output on a card that supports both mono and stereo. But
> > > > that seems quite unlikely.
> > > > ---
> > > >   src/modules/alsa/alsa-mixer.c                  |  1 +
> > > >   .../alsa/mixer/profile-sets/default.conf       | 18 ++++++++++--------
> > > >   2 files changed, 11 insertions(+), 8 deletions(-)
> > > > 
> > > 
> > > Looks good to me. I don't mind having it in 12.0, but let Arun have
> > > the last word.
> > > 
> > > BTW, when are we going to release 12.0? I have not heard any
> > > complaints yet.
> > 
> > Next week seems possible. Hopefully Arun can comment on this patch.
> > 
> > -- 
> 
> From a risk perspective, if there are no or barely any complaints
> around this, I would rather ship 12.0 now and push to next.

I've seen one complaint, which I guess means that this issue goes to
the "barely any complaints" category. I'll push this just to the next
branch then.

-- 
Tanu

https://liberapay.com/tanuk
https://www.patreon.com/tanuk