[pulseaudio-discuss] [PATCH] bluetooth: backend-ofono: Demote registration failure to info

Luiz Augusto von Dentz luiz.dentz at gmail.com
Wed Jun 27 08:16:35 UTC 2018


Hi Joao,

On Wed, Jun 27, 2018 at 1:26 AM, João Paulo Rechi Vita
<jprvita at gmail.com> wrote:
> Now that both backend-native and backend-ofono can coexist and
> backend-ofono is always loaded, even on systems without oFono, failing
> to register with org.ofono is not necessarily an error.
>
> This lowers the failure message log level from error to info.
> ---
>  src/modules/bluetooth/backend-ofono.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c
> index 2c51497f3..0af1c14df 100644
> --- a/src/modules/bluetooth/backend-ofono.c
> +++ b/src/modules/bluetooth/backend-ofono.c
> @@ -372,8 +372,8 @@ static void hf_audio_agent_register_reply(DBusPendingCall *pending, void *userda
>      pa_assert_se(r = dbus_pending_call_steal_reply(pending));
>
>      if (dbus_message_get_type(r) == DBUS_MESSAGE_TYPE_ERROR) {
> -        pa_log_error("Failed to register as a handsfree audio agent with ofono: %s: %s",
> -                     dbus_message_get_error_name(r), pa_dbus_get_error_message(r));
> +        pa_log_info("Failed to register as a handsfree audio agent with ofono: %s: %s",
> +                    dbus_message_get_error_name(r), pa_dbus_get_error_message(r));
>          goto finish;
>      }
>
> --
> 2.18.0

LGTM.

-- 
Luiz Augusto von Dentz


More information about the pulseaudio-discuss mailing list