[pulseaudio-discuss] [PATCH] switch-on-port-available: ignore bluetooth cards

[Georg Chini]

On 29.06.2018 13:33, Tanu Kaskinen wrote:
> When the user manually switches the profile of a bluetooth headset from
> "off" to "a2dp_sink", the port availability changes from "unknown" to
> "yes", which triggered a recursive profile change in
> module-switch-on-port-available. Such recursivity isn't (and possibly
> can't) be handled well (that is, PulseAudio crashed), so let's avoid
> doing bluetooth profile changes from module-switch-on-port-available
> (they're useless anyway).
>
> Bug link: https://bugs.freedesktop.org/show_bug.cgi?id=107044
> ---
>   src/modules/module-switch-on-port-available.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c
> index 8fd3c9e5f..321db361f 100644
> --- a/src/modules/module-switch-on-port-available.c
> +++ b/src/modules/module-switch-on-port-available.c
> @@ -281,6 +281,14 @@ static pa_hook_result_t port_available_hook_callback(pa_core *c, pa_device_port
>           return PA_HOOK_OK;
>       }
>   
> +    /* Our profile switching logic caused trouble with bluetooth headsets (see
> +     * https://bugs.freedesktop.org/show_bug.cgi?id=107044) and
> +     * module-bluetooth-policy takes care of automatic profile switching
> +     * anyway, so we ignore bluetooth cards in
> +     * module-switch-on-port-available. */
> +    if (pa_safe_streq(pa_proplist_gets(port->card->proplist, PA_PROP_DEVICE_BUS), "bluetooth"))
> +        return PA_HOOK_OK;
> +
>       switch (port->available) {
>       case PA_AVAILABLE_YES:
>           switch_to_port(port);

LGTM