[pulseaudio-discuss] [PATCH v2 0/5] State change refactoring, port change crash fix
Tanu Kaskinen
tanuk at iki.fi
Tue Mar 13 17:40:35 UTC 2018
Followup to the "Sink/source state change fixes" patch set. As discussed
in the review thread, I have renamed the set_state() callbacks to
set_state_in_main_thread() and added a new callback,
set_state_in_io_thread(), which replaces almost all SET_STATE handlers
from sink and source implementations.
I noticed a bug in module-oss when moving the SET_STATE handler code, so
there's one patch about that.
Tanu Kaskinen (5):
sink, source: rename set_state() to set_state_in_main_thread()
oss: don't fail resume if trigger() fails
replace sink/source SET_STATE handlers with callbacks
pass pa_suspend_cause_t to set_state_in_io_thread() callbacks
fix a call to pa_sink_suspend() from an incorrect thread
src/modules/alsa/alsa-sink.c | 186 +++++++++++++++++--------
src/modules/alsa/alsa-source.c | 186 +++++++++++++++++--------
src/modules/bluetooth/module-bluez4-device.c | 172 ++++++++++++-----------
src/modules/bluetooth/module-bluez5-device.c | 174 ++++++++++++-----------
src/modules/echo-cancel/module-echo-cancel.c | 39 +++---
src/modules/macosx/module-coreaudio-device.c | 8 +-
src/modules/module-combine-sink.c | 42 ++++--
src/modules/module-equalizer-sink.c | 34 +++--
src/modules/module-esound-sink.c | 64 +++++----
src/modules/module-ladspa-sink.c | 34 +++--
src/modules/module-null-sink.c | 25 ++--
src/modules/module-null-source.c | 21 ++-
src/modules/module-pipe-sink.c | 45 +++---
src/modules/module-remap-sink.c | 34 +++--
src/modules/module-remap-source.c | 4 +-
src/modules/module-sine-source.c | 21 ++-
src/modules/module-solaris.c | 136 ++++++++++--------
src/modules/module-tunnel-sink-new.c | 53 ++++---
src/modules/module-tunnel-source-new.c | 53 ++++---
src/modules/module-tunnel.c | 8 +-
src/modules/module-virtual-sink.c | 34 +++--
src/modules/module-virtual-source.c | 8 +-
src/modules/module-virtual-surround-sink.c | 34 +++--
src/modules/oss/module-oss.c | 199 +++++++++++++++------------
src/modules/raop/raop-sink.c | 126 +++++++++--------
src/pulsecore/sink.c | 119 +++++++---------
src/pulsecore/sink.h | 38 +++--
src/pulsecore/source.c | 119 +++++++---------
src/pulsecore/source.h | 38 +++--
29 files changed, 1193 insertions(+), 861 deletions(-)
--
2.16.1
More information about the pulseaudio-discuss
mailing list