[pulseaudio-discuss] [PATCH 2/3] bluetooth: Remove BlueZ 4 support

[Luiz Augusto von Dentz]

Hi Tanu.

On Thu, Mar 15, 2018 at 10:26 PM, Tanu Kaskinen <tanuk at iki.fi> wrote:
> On Fri, 2018-03-09 at 14:12 +0200, Luiz Augusto von Dentz wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz at intel.com>
>>
>> BlueZ 4 is no longer supported by BlueZ community for a long long time,
>> also by moving to BlueZ 5 it should make it even more clearer that
>> BlueZ 4 is no longer an option.
>> ---
>>  configure.ac                                      |   16 +-
>>  po/POTFILES.in                                    |    1 -
>>  po/be.po                                          |   16 -
>>  po/de.po                                          |   16 -
>>  po/el.po                                          |   16 -
>>  po/fr.po                                          |   16 -
>>  po/hr.po                                          |   16 -
>>  po/hu.po                                          |   16 -
>>  po/it.po                                          |   16 -
>>  po/lt.po                                          |   16 -
>>  po/nn.po                                          |   16 -
>>  po/oc.po                                          |   16 -
>>  po/pl.po                                          |   16 -
>>  po/pt_BR.po                                       |   16 -
>>  po/ru.po                                          |   16 -
>>  po/sk.po                                          |   16 -
>>  po/sv.po                                          |   16 -
>>  po/tr.po                                          |   16 -
>>  po/uk.po                                          |   16 -
>>  po/zh_CN.po                                       |   16 -
>>  po/zh_TW.po                                       |   16 -
>>  src/Makefile.am                                   |   26 -
>>  src/modules/bluetooth/bluez4-util.c               | 1851 --------------
>>  src/modules/bluetooth/bluez4-util.h               |  160 --
>>  src/modules/bluetooth/module-bluetooth-discover.c |   13 +-
>>  src/modules/bluetooth/module-bluez4-device.c      | 2656 ---------------------
>>  src/modules/bluetooth/module-bluez4-discover.c    |  187 --
>>  27 files changed, 3 insertions(+), 5211 deletions(-)
>>  delete mode 100644 src/modules/bluetooth/bluez4-util.c
>>  delete mode 100644 src/modules/bluetooth/bluez4-util.h
>>  delete mode 100644 src/modules/bluetooth/module-bluez4-device.c
>>  delete mode 100644 src/modules/bluetooth/module-bluez4-discover.c
>
> Quoting my previous review:
>
> "git grep -i "bluez 4" still returns some hits in module-bluetooth-
> policy.c."
>
> That's still the case.
>
> I believe the translation files don't need to be updated (except
> POTFILES.in), but if you update them, this doesn't look right:
>
>> -#: ../src/modules/bluetooth/module-bluez4-device.c:2176
>>  msgid "High Fidelity Playback (A2DP)"
>>  msgstr "Прайграванне высокай якасці (A2DP)"
>
> I think the whole message should be removed when there are no more
> references to it.

Fixed in v2.

> --
> Tanu
>
> https://liberapay.com/tanuk
> https://www.patreon.com/tanuk



-- 
Luiz Augusto von Dentz