[pulseaudio-discuss] [PATCH v3] Fix memory leaks

Tanu Kaskinen tanuk at iki.fi
Fri Mar 23 14:36:53 UTC 2018


On Fri, 2018-03-23 at 17:26 +0900, Jungsup Lee wrote:
> The returned string of the dbus_message_iter_get_signature() must be freed with dbus_free().
> ---
>  src/modules/module-stream-restore.c | 7 ++++++-
>  src/pulsecore/dbus-util.c           | 7 ++++++-
>  src/pulsecore/protocol-dbus.c       | 6 +++++-
>  3 files changed, 17 insertions(+), 3 deletions(-)

Thanks! Applied. I changed pa_assert(signature = ...) to use
pa_assert_se() instead, because code in pa_assert() can be removed by
defining NDEBUG, and it would be bad if the variable assignments were
removed. pa_assert_se() never removes the contained code. ("se" refers
to "side effects", and a variable assignment is a side effect.)

-- 
Tanu

https://liberapay.com/tanuk
https://www.patreon.com/tanuk


More information about the pulseaudio-discuss mailing list