[pulseaudio-discuss] [PATCH] ladspa-sink: fix incorrect error conditions

[Tanu Kaskinen]

On Fri, 2018-05-04 at 02:00 +0900, Sangchul Lee wrote:
> From: Sangchul Lee <sangchul1011 at gmail.com>
> 
> fix codes to prevent null pointer dereference of cdata variable.
> 
> Signed-off-by: Sangchul Lee <sc11.lee at samsung.com>
> ---
>  src/modules/module-ladspa-sink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/modules/module-ladspa-sink.c b/src/modules/module-ladspa-sink.c
> index d677381..c365b31 100644
> --- a/src/modules/module-ladspa-sink.c
> +++ b/src/modules/module-ladspa-sink.c
> @@ -718,7 +718,7 @@ static int parse_control_parameters(struct userdata *u, const char *cdata, doubl
>  
>      pa_log_debug("Trying to read %lu control values", u->n_control);
>  
> -    if (!cdata && u->n_control > 0)
> +    if (!cdata || u->n_control == 0)
>          return -1;
>  
>      pa_log_debug("cdata: '%s'", cdata);

Thanks! Applied.

-- 
Tanu

https://liberapay.com/tanuk
https://www.patreon.com/tanuk