[pulseaudio-discuss] [PATCH v4] bluez5-device: Rewrite of thread function, reduce send buffer size for a2dp sink
tanuk at iki.fi
Mon May 7 14:16:54 UTC 2018
On Fri, 2018-05-04 at 21:10 +0200, Georg Chini wrote:
> The rewrite of the thread function does not change functionality much,
> most of it is only cleanup, minor bug fixing and documentation work.
> This patch also changes the send buffer size for a2dp sink to avoid lags
> after temporary connection drops, following the proof-of-concept patch
> posted by Dmitry Kalyanov.
> Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=58746
> Additionally the patch changes the fixed latency for HSP playback from 125
> to 25 ms. Tests showed that this produces better audio sync, which is
> expected as HSP should have smaller latency than A2DP.
> Changes in v3:
> - fix issues pointed out by Tanu
> - set writable to false for HSP only if a block really needs to be written
> Changes in v4:
> - Add comment suggested by Tanu
> - Change commit message
> src/modules/bluetooth/module-bluez5-device.c | 300 ++++++++++++++++++---------
> 1 file changed, 202 insertions(+), 98 deletions(-)
Looks good to me. Thanks again for working on this issue!
More information about the pulseaudio-discuss