[pulseaudio-discuss] [paprefs][PATCH 9/9] Port from GTK2 to GTK3

[NicoHood]

On 05/12/2018 05:40 PM, Felipe Sateler wrote:
> 
> 
> On Fri, May 11, 2018 at 9:23 AM NicoHood <pulseaudio-discuss at nicohood.de
> <mailto:pulseaudio-discuss at nicohood.de>> wrote:
> 
>     On 04/17/2018 08:25 AM, Tanu Kaskinen wrote:
>     > From: Felipe Sateler <fsateler at debian.org
>     <mailto:fsateler at debian.org>>
>     >
>     > Switch from libglade to GtkBuilder, as that is the new preferred
>     interface.
>     > ---
>     >  configure.ac <http://configure.ac>      |   2 +-
>     >  src/paprefs.cc    |  10 +--
>     >  src/paprefs.glade | 224
>     ++++++++++++++++++++++++++----------------------------
>     >  3 files changed, 110 insertions(+), 126 deletions(-)
>     >
>     > [..]
> 
>     I pulled the current master (534d20a1d738f21365b56a08f6553d1be8ca8914)
>     which should now have gtk3 support. I tried to open it in glade, but I
>     get lots of warnings that some widgets are not supported by the gtk
>     version or are dperecated at all. I could fix some warnings by
>     specifying the latest gtk version, but still the fixes seem incomplete
>     to me.
> 
>     I originally wanted to port my loopback module patch, but it seems I
>     can't do that with the current glade file. I am not that experienced in
>     gtk development, so I hope someone can help me. I am using ArchLinux
>     with the latest gtk3.22.30-1.
> 
> 
> It seems glade is a bit more strict than the actual gtkbuilder, because
> the only change required to stop the complaints is this:
> 
> diff --git a/src/paprefs.glade b/src/paprefs.glade
> index 401e9c1..39bc828 100644
> --- a/src/paprefs.glade
> +++ b/src/paprefs.glade
> @@ -1,7 +1,6 @@
>  <?xml version="1.0"?>
>  <interface>
> -  <!-- interface-requires gtk+ 2.16 -->
> -  <!-- interface-naming-policy toplevel-contextual -->
> +  <requires lib="gtk+" version="3.0"/>
>    <object class="GtkWindow" id="mainWindow">
>      <property name="can_focus">False</property>
>      <property name="title" translatable="yes">PulseAudio
> Preferences</property>
> 
> -- 
> 
> Saludos,
> Felipe Sateler
> 
> 
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> 

I already tried that, but I still got those warnings:
https://user-images.githubusercontent.com/6888294/39965281-5077c8e8-5696-11e8-8522-f4746acfc893.png

On the right: "This property was introduced in gtk+ 3.10 while project
targets gtk+ 3.0"

I could fix this by specifying 3.22.

But on the left it sais "This widget is depreciated". I guess this needs
to get fixed, otherwise we need to patch papref again soon.

Nico