[pulseaudio-discuss] avoid-resampling -> avoid-processing

[Arun Raghavan]

On Fri, 26 Oct 2018, at 11:07 AM, Sangchul Lee wrote:
> 2018년 10월 25일 (목) 오후 11:34, Tanu Kaskinen <tanuk at iki.fi>님이 작성:
> >
> > On Mon, 2018-10-15 at 09:59 +0530, Arun Raghavan wrote:
> > >
> > > On Thu, 27 Sep 2018, at 11:13 AM, Sangchul Lee wrote:
> > > > 2018년 9월 27일 (목) 오후 12:30, Arun Raghavan <arun at arunraghavan.net>님이 작성:
> > > > > On Wed, 26 Sep 2018, at 5:15 PM, Sangchul Lee wrote:
> > > > > > > > We could provide more fine-grained control (avoid-resampling/-
> > > > > > > > remapping/-conversion/-channel-mix), but I don't see the benefit of
> > > > > > > > this, so I figure a more overarching option is more likely to be
> > > > > > > > useful.
> > > > > > > >
> > > > > > > > Would be nice to hear people's thoughts on this.
> > > > > > >
> > > > > > > Having an "avoid-processing" option is a good idea. I'm not sure what
> > > > > > > your proposal is for the old "avoid-resampling" option in daemon.conf.
> > > > > > > I'd like to keep that separate, so that it only affects sample rate
> > > > > > > conversion.
> > > > > >
> > > > > > I understood the backward compatibility you said. Do I need to modify
> > > > > > the patch expanding bit-depth("Consider sample format for
> > > > > > avoid-resampling/passthrough") with the new 'avoid-processing' option?
> > > > > > (I might upload a patch to the gitlab next time.)
> > > > >
> > > > > I've got a bunch of  changes waiting on top of hte existing passthrough test MR. You probably should work off that. I've got the changes at https://gitlab.freedesktop.org/arun/pulseaudio/tree/reconfigure
> > > >
> > > > I checked commits on your local branch including replacing the option
> > > > name. It will be great to have the previous option with some logs for
> > > > guide according to the "The next best alternative" of tanu's opinion.
> > > >
> > > > And for now, I'll share V3 of "Consider sample format.." patch without
> > > > changing the name via email soon.
> > >
> > > I've implemented this feedback, some automated tests, and other review comments in:
> > >
> > >   https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/24
> >
> > It's a bit unclear to me what the relationship between this MR and
> > "[PATCH v3] alsa-sink/source, sink, source: Consider sample format for
> > avoid-resampling/passthrough" is. Do you two have a common
> > understanding about which should be reviewed first?
> 
> This single patch is the last commit of my patch series for expanding
> 'avoid-' functionalities including checking with supported sample
> formats/rates and resetting hw param. And I think it is still needed
> even if the arun's MR which is wider rage - function parameter
> extension, channel-map things, renaming and null-sink modification -
> is merged. So I'd like to ask you to review this patch first(I think
> it is almost done..) and then rebase arun's MR 'if possible'.

I'm happy to rebase my work on top of this.

Regards,
Arun