[pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support
Luiz Augusto von Dentz
luiz.dentz at gmail.com
Fri Jan 11 18:32:44 UTC 2019
Hi Pali,
On Fri, Jan 11, 2019 at 2:49 PM Pali Rohár <pali.rohar at gmail.com> wrote:
>
> On Friday 11 January 2019 14:23:21 Luiz Augusto von Dentz wrote:
> > Im little worried about the maintainance of a2dp_util.c if we keedp
> > the practice of #ifsef every codec, imo it would be much cleaner if we
> > just have a mechanism to register the codecs, maybe we load them as
> > separate plugins which then call a2dp_util.c to register their
> > 'drivers', the plugin can check if the bluetooth plugin is loaded in
> > order to register itself, doing that way we can also pass the
> > parameter via default.pa.
>
> Hi! I'm already working on a new version of my previous patch series.
> And your above point above tons of #ifdefs is being addresses.
>
> I though about it for a long time (heh :-) last version of my A2DP codec
> patch series is from summer) and I think I have a good API where adding
> new codec involves only adding new file (with all needed functions) plus
> putting codec structure into one list.
>
> So... I will rework my previous patch series, will add support for codec
> switching and then I send it to mailing list.
Are you changes compatibles with this changes or we have to competing solutions?
More information about the pulseaudio-discuss
mailing list