[pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

[Pali Rohár]

On Thursday 24 January 2019 18:17:08 Pali Rohár wrote:
> On Thursday 24 January 2019 18:54:18 Luiz Augusto von Dentz wrote:
> > > > > +    set_params(sbc_info);
> > > > > +
> > > > > +    PA_ONCE_BEGIN {
> > > > > +        pa_log_debug("Using SBC codec implementation: %s", pa_strnull(sbc_get_implementation_info(&sbc_info->sbc)));
> > > >
> > > > This was printing NULL to me which I suspect is the reason why you
> > > > have pa_strnull(?), anyway it is not enough to just call sbc_init
> > > > since that doesn't call sbc_init_primitives. We could in theory change
> > > > that to be part of sbc_init instead of on the first call to
> > > > sbc_encode.
> > >
> > > Also this code block is just moving from one file to another.
> > >
> > > I do not know why pa_strnull was there before.
> > 
> > Seems this has been broken for a while.
> 
> Yes.

Apparently not, this is my mistake. I incorrectly moved this block from
encode to init. Fixed locally (moved back to encode function) and it
will be in next patch version.

> > > > > +    } PA_ONCE_END;
> > > > > +
> > > > > +    pa_log_info("SBC parameters: allocation=%u, subbands=%u, blocks=%u, bitpool=%u",
> > > > > +                sbc_info->sbc.allocation, sbc_info->sbc.subbands ? 8 : 4, sbc_info->sbc.blocks, sbc_info->sbc.bitpool);
> > > > > +
> > > > > +    return sbc_info;
> > > > > +}

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20190127/5eb9d8c4/attachment.sig>