[pulseaudio-discuss] [PATCH v12 00/13] Bluetooth A2DP codecs

[Tanu Kaskinen]

On Sun, 2019-07-21 at 17:07 +0200, Pali Rohár wrote:
> On Thursday 18 July 2019 09:12:15 Tanu Kaskinen wrote:
> > On Fri, 2019-07-05 at 15:02 +0200, Pali Rohár wrote:
> > > Changes in v12:
> > > * Renamed SBC UHQ to SBC XQ to match naming convention from
> > >   http://soundexpert.org/articles/-/blogs/audio-quality-of-sbc-xq-bluetooth-audio-codec
> > > * Throw error when PA receive fragmented SBC frame
> > > * Log "Couldn't find SO_TIMESTAMP" warning message only once
> > > * Update comment for SBC bitpool selection
> > > * Add more checks for return values from libsbc
> > > * Propagate error value from sbc_reinit() to module-bluez5-device.c
> > > * Add checks for SBC frame count
> > > * Completely rework/fix MTU, buffer sizes and return values of encode/decode methods
> > > 
> > > Pali Rohár (13):
> > >   bluetooth: Fix usage of MTU, buffer sizes and return values of
> > >     encode/decode methods
> > >   bluetooth: Change A2DP codec API of reset() method to indicate failure
> > >   bluetooth: Fix usage of RTP structures in SBC codec
> > >   bluetooth: Implement reading SO_TIMESTAMP for A2DP source
> > >   bluetooth: Print SO_TIMESTAMP warning for SCO source only once
> > >   bluetooth: Parse remote timestamp from A2DP RTP packets when available
> > >   bluetooth: Set initial A2DP profile which bluez already activated
> > >   bluetooth: Add A2DP aptX and aptX HD codecs support
> > >   bluetooth: Add A2DP FastStream codec support
> > >   bluetooth: Add more variants of SBC codec
> > >   bluetooth: policy: Reflect a2dp profile names
> > >   bluetooth: Implement A2DP codec switching and backchannel support
> > >   bluetooth: policy: Treat bi-directional A2DP profiles as suitable for
> > >     VOIP
> > > 
> > >  configure.ac                                    |  36 ++
> > >  src/Makefile.am                                 |   8 +
> > >  src/modules/bluetooth/a2dp-codec-api.h          |  14 +-
> > >  src/modules/bluetooth/a2dp-codec-aptx.c         | 448 +++++++++++++
> > >  src/modules/bluetooth/a2dp-codec-faststream.c   | 454 +++++++++++++
> > >  src/modules/bluetooth/a2dp-codec-sbc.c          | 806 +++++++++++++++++++-----
> > >  src/modules/bluetooth/a2dp-codec-util.c         |  26 +-
> > >  src/modules/bluetooth/bluez5-util.c             | 476 +++++++++++++-
> > >  src/modules/bluetooth/bluez5-util.h             |  39 +-
> > >  src/modules/bluetooth/meson.build               |   1 +
> > >  src/modules/bluetooth/module-bluetooth-policy.c | 127 ++--
> > >  src/modules/bluetooth/module-bluez5-device.c    | 587 ++++++++++++-----
> > >  src/modules/bluetooth/module-bluez5-discover.c  |   3 +-
> > >  src/modules/bluetooth/rtp.h                     |  58 +-
> > >  14 files changed, 2644 insertions(+), 439 deletions(-)
> > >  create mode 100644 src/modules/bluetooth/a2dp-codec-aptx.c
> > >  create mode 100644 src/modules/bluetooth/a2dp-codec-faststream.c
> > 
> > Can you fix and resubmit the first three patches? Those are the ones we
> > want in the upcoming release.
> 
> I fixed issues which you reported and sent updated first 3 patches.

Thanks! I applied them all now.

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk