<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 20.02.2016 03:24, Sangchul Lee
wrote:<br>
</div>
<blockquote
cite="mid:CANQ8By_6Rm7F4Q3-1bgy=oTA5B57vevbAVR8_nF9hG9iwRC3=Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>Thanks for your comment. I checked the link minutes ago.</div>
<div><br>
</div>
<div>The intention for reducing code duplication seems good.</div>
<div>However I'm still wondering whether it is necessary because
there's a possibility to extend functionality and to change
its structure of ducking module except cork module.</div>
<div>This issue would be discussed by maintainers.<br>
</div>
<div><br>
</div>
<div>Anyway, I'm going to consider to apply my patch to your
works after your codes are merged to upstream codes. (I'll
contact you then)</div>
<div><br>
</div>
<div>Regards,<br>
</div>
<div>Sangchul Lee</div>
<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-02-20 6:27 GMT+09:00 Georg Chini
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:georg@chini.tk" target="_blank">georg@chini.tk</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
if you are working on the two modules, maybe you can<br>
use the patch set at<br>
<a moz-do-not-send="true"
href="http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/23189"
rel="noreferrer" target="_blank">http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/23189</a><br>
which combines the two modules. This avoids unnecessary
code duplication.<br>
The patch set has never been reviewed. I already sent a
mail to the list, but<br>
I don't know if you have seen it.<br>
If you are interested and have problems getting the
patches from the link above,<br>
I can send them to you via mail.<br>
<br>
Regards<span class=""><font color="#888888"><br>
Georg<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</blockquote>
Hi,<br>
<br>
thanks for your response. My code will probably never be merged, I
sent the patch<br>
about a year ago and nobody ever cared to review it. So I thought
you might want<br>
to pick up the idea, as you are obviously working on the module and
got some<br>
response from the maintainers. Since your code might be merged into
upstream<br>
now, I would have to rewrite the patch series to take your changes
into account,<br>
which I will probably never do.<br>
I thought it might be a good idea if you do the consolidation first
and then apply<br>
your changes to avoid duplicate work. To me it seems that having
different feature<br>
sets for the two modules does not make a lot of sense, because they
are used for<br>
the same purpose.<br>
<br>
Regards<br>
Georg<br>
</body>
</html>