<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 15 July 2016 at 11:14, David Henningsson <span dir="ltr"><<a href="mailto:diwic@ubuntu.com" target="_blank">diwic@ubuntu.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 2016-07-15 11:05, Wim Taymans wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Hi guys,<br>
<br>
I'm having another look at the access control patches. I revived my old<br>
patches and found some trouble with the async stuff that I fixed here:<br>
<br>
</span><a href="https://cgit.freedesktop.org/~wtay/pulseaudio/log/?h=access-hooks" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/~wtay/pulseaudio/log/?h=access-hooks</a> <<a href="https://cgit.freedesktop.org/%7Ewtay/pulseaudio/log/?h=access-hooks" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/%7Ewtay/pulseaudio/log/?h=access-hooks</a>><br>
</blockquote>
<br>
FWIW, I also remember fixing a bug or two before I added your patches to Ubuntu. The way it looks in Ubuntu now is here:<br>
<br>
<a href="http://anonscm.debian.org/cgit/pkg-pulseaudio/pulseaudio.git/tree/debian/patches?h=ubuntu" rel="noreferrer" target="_blank">http://anonscm.debian.org/cgit/pkg-pulseaudio/pulseaudio.git/tree/debian/patches?h=ubuntu</a><br>
<br>
(see patches 0406, 0407 and 0408)<br></blockquote><div><br></div><div>It looks ok, you fixed the length in _copy and the reading of the command and tag when resuming the async operation.</div><div><br></div><div>Interestingly you added the pa_creds to the pa_client. Any reason not to upstream this?</div><div><br></div><div>Wim</div><div><br></div><div><br></div></div></div></div>