<div dir="ltr"><div><div>So glad to hear this is landing in the main branch, having run Hajime's code for at least a couple of years.<br><br></div>Thanks to everyone involved in getting this landed.<br><br></div>Toby Haynes<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 12 Jan 2017 at 22:57 Hajime Fujita <<a href="mailto:crisp.fujita@nifty.com">crisp.fujita@nifty.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Jan 12, 2017, at 7:46 PM, Tanu Kaskinen <<a href="mailto:tanuk@iki.fi" class="gmail_msg" target="_blank">tanuk@iki.fi</a>> wrote:</div><br class="m_-8937934209885980955Apple-interchange-newline gmail_msg"><div class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">On Tue, 2017-01-10 at 22:23 -0600, Hajime Fujita wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg">Hi Tanu and Anton,<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">On Jan 10, 2017, at 5:57 PM, Tanu Kaskinen <<a href="mailto:tanuk@iki.fi" class="gmail_msg" target="_blank">tanuk@iki.fi</a>> wrote:<br class="gmail_msg"><br class="gmail_msg">On Thu, 2017-01-05 at 22:34 +0100, Anton Lundin wrote:<br class="gmail_msg"><blockquote type="cite" class="gmail_msg">On 06 November, 2016 - Hajime Fujita wrote:<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">This patch set adds a support for UDP version of RAOP (so called<br class="gmail_msg">raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,<br class="gmail_msg">third party AV receivers) today use UDP version, so this patch<br class="gmail_msg">set is expected to support those devices.<br class="gmail_msg"><br class="gmail_msg"></blockquote><br class="gmail_msg">I've took a close look at the non-raop changes and those LGTM.<br class="gmail_msg"><br class="gmail_msg">Feel free to add a Reviewed-by: Anton Lundin <<a href="mailto:glance@acc.umu.se" class="gmail_msg" target="_blank">glance@acc.umu.se</a>> to them<br class="gmail_msg">if you feel for it.<br class="gmail_msg"><br class="gmail_msg">I've tested and glanced at the raop-code and it ain't perfect but its<br class="gmail_msg">way better than the current code for anything modern, so I'd suggest<br class="gmail_msg">merging this.<br class="gmail_msg"><br class="gmail_msg">Feel free to add a Tested-by: Anton Lundin <<a href="mailto:glance@acc.umu.se" class="gmail_msg" target="_blank">glance@acc.umu.se</a>> to them<br class="gmail_msg">if you feel for it.<br class="gmail_msg"></blockquote></blockquote><br class="gmail_msg">First, thank you Anton for taking a look at this patch set and supporting merging it.<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg"><br class="gmail_msg">Thanks, I pushed the three core-util patches to the "next" branch. I<br class="gmail_msg">started to apply the rest of the patches too, but the first raop patch<br class="gmail_msg">failed to build:<br class="gmail_msg"><br class="gmail_msg">CC modules/raop/module_raop_sink_la-module-raop-sink.lo<br class="gmail_msg">modules/raop/module-raop-sink.c: In function ‘udp_thread_func’:<br class="gmail_msg">modules/raop/module-raop-sink.c:724:19: error: too many arguments to function ‘pa_rtpoll_run’<br class="gmail_msg"> if ((rv = pa_rtpoll_run(u->rtpoll, true)) < 0)<br class="gmail_msg"> ^~~~~~~~~~~~~<br class="gmail_msg">In file included from ./pulsecore/source.h:41:0,<br class="gmail_msg"> from ./pulsecore/core.h:49,<br class="gmail_msg"> from ./pulsecore/sink.h:33,<br class="gmail_msg"> from modules/raop/module-raop-sink.c:44:<br class="gmail_msg">./pulsecore/rtpoll.h:61:5: note: declared here<br class="gmail_msg">int pa_rtpoll_run(pa_rtpoll *f);<br class="gmail_msg"> ^~~~~~~~~~~~~<br class="gmail_msg">Makefile:9124: recipe for target 'modules/raop/module_raop_sink_la-module-raop-sink.lo' failed<br class="gmail_msg"><br class="gmail_msg">Maybe that's fixed in later patches, but for bisecting it's best to<br class="gmail_msg">avoid commits that break the build.<br class="gmail_msg"></blockquote><br class="gmail_msg">I thought I have fixed this before, but apparently it was incomplete. Sorry about that. It should have been fixed as you suggested.<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">I also tried to build the whole patch set, but Debian has updated to<br class="gmail_msg">openssl 1.1.0, and at the time when these patches were submitted, we<br class="gmail_msg">didn't yet have the patch that fixes the compatibility issue with<br class="gmail_msg">openssl 1.1.0, so that failed too. Trying to apply both the openssl fix<br class="gmail_msg">and the raop patches results in conflicts.<br class="gmail_msg"><br class="gmail_msg">These issues should be easy enough to resolve, and if there's nothing<br class="gmail_msg">more complicated, I'll fix the issues myself and push the patches.<br class="gmail_msg"></blockquote><br class="gmail_msg">That’ll be awesome.<br class="gmail_msg">But if you need my help I’d be more than happy to do so.<br class="gmail_msg"></blockquote><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">And so ends this journey of several years... I pushed these patches to</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">the "next" branch now. Thank you all for your work and patience!</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"></div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">Awesome! Thank you for your patience as well.</div><div class="gmail_msg">So I guess this is going to be in the 11.0 release?</div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">--<span class="m_-8937934209885980955Apple-converted-space gmail_msg"> </span></span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">Tanu</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><a href="https://www.patreon.com/tanuk" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg" target="_blank">https://www.patreon.com/tanuk</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">pulseaudio-discuss mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><a href="mailto:pulseaudio-discuss@lists.freedesktop.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg" target="_blank">pulseaudio-discuss@lists.freedesktop.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><a href="https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss</a></div></blockquote></div></div>_______________________________________________<br class="gmail_msg">
pulseaudio-discuss mailing list<br class="gmail_msg">
<a href="mailto:pulseaudio-discuss@lists.freedesktop.org" class="gmail_msg" target="_blank">pulseaudio-discuss@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss</a><br class="gmail_msg">
</blockquote></div>