<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10.04.2017 10:14, KimJeongYeon
wrote:<br>
</div>
<blockquote
cite="mid:CAPoUOUKXKcE+rR3fMS8rQMC9hs8uZBgQpQTQ8Ehw3e0FW44ciw@mail.gmail.com"
type="cite">
<div dir="auto">
<div><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017. 4. 9. 오전 5:22에 "Georg Chini"
<<a moz-do-not-send="true" href="mailto:georg@chini.tk">georg@chini.tk</a>>님이
작성:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="quoted-text">On 07.04.2017 15:41,
KimJeongYeon wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
For example, a normal stream tried to attach to
filter sink(or source), which<br>
filter loaded and managed by filter-apply. But, the
stream become to attach to<br>
the ***master sink(or source)*** of filter module
due to restoring operation.<br>
It seems should to be attached to the filter sink(or
source) properly.<br>
<br>
</blockquote>
</div>
I do not think this is the right fix for the problem.
With your patch, if<br>
the property list of a stream without filter.apply set
is changed, the<br>
stream will still falsely be moved to the master sink.<br>
I believe the right way to solve it would be to set the
filter.apply property<br>
and module_name when the sink_input_put hook is called
and the sink is<br>
a filter sink.<br>
<br>
I also wonder why you use an enumeration when you only
use one<br>
of the values. A boolean is_put argument to process()
would do.<br>
<br>
Regards<font color="#888888"><br>
Georg<br>
</font></blockquote>
</div>
<br>
</div>
</div>
<div class="gmail_extra" dir="auto">You are right. I'll submit
patch again soon.</div>
</div>
</blockquote>
Thinking again, it looks that my suggestion also does not cover all
cases. When the<br>
stream is moved away from the filter sink, it will have filter.apply
set which it did not<br>
have initially. This is obviously wrong, so we need an additional
property to indicate<br>
that filter.apply was set by module-filter-apply and that it can be
removed when the<br>
stream moves away from the filter. Also I have only been talking
about the put hook.<br>
The same applies to the move_finished hook.<br>
<br>
But you have been working with the code for a while now, so maybe
you can come<br>
up with a better solution.<br>
<br>
Also Arun might object to my idea. He asked me to summarize and
wanted to reply<br>
on the list. So maybe you wait until he confirmed/rejected.<br>
<br>
</body>
</html>