<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 21.04.2017 00:38, KimJeongYeon
wrote:<br>
</div>
<blockquote
cite="mid:CAPoUOUJSLJwJZxqU=dC9E2MO+iVbTAZag8sc1gimDy7iJ=q_ZA@mail.gmail.com"
type="cite">
<div dir="auto">
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017. 4. 21. 오전 3:28에 "Georg Chini"
<<a moz-do-not-send="true" href="mailto:georg@chini.tk">georg@chini.tk</a>>님이
작성:
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Still found a few issues, but I think the next version
will be final.
<div class="quoted-text"><br>
</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="quoted-text">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">+<br>
+ trigger_housekeeping(u);<br>
+ return PA_HOOK_OK; /* goto done; */<br>
</blockquote>
<br>
</div>
You forget to free module_name. I would move the "done"
label before the<br>
"if (done_something)" and do "done_something=true; goto
done" here.</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div dir="auto" style="font-family:sans-serif">Sorry. It was
my mistake while doing my local merging. 'goto done;' is
correct.</div>
</div>
</div>
</blockquote>
<br>
Still I would not call trigger_housekeeping() here but instead move
the "done" label.<br>
But I don't mind if you prefer it otherwise.<br>
<br>
<blockquote
cite="mid:CAPoUOUJSLJwJZxqU=dC9E2MO+iVbTAZag8sc1gimDy7iJ=q_ZA@mail.gmail.com"
type="cite">
<div dir="auto"><br>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="quoted-text">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
static pa_hook_result_t
source_output_proplist_cb(pa_c<wbr>ore *core,
pa_source_output *o, struct userdata *u) {<br>
pa_core_assert_ref(core);<br>
pa_source_output_assert_ref(o)<wbr>;<br>
</blockquote>
<br>
</div>
Didn't you want to avoid the double move here? Or will
that be another patch?</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto"><span style="font-family:sans-serif">I hope
submit another patch. It might be regarded as another issue.</span><br>
</div>
<div dir="auto"><span style="font-family:sans-serif"><br>
</span></div>
</div>
</blockquote>
<br>
OK.<br>
<br>
<blockquote
cite="mid:CAPoUOUJSLJwJZxqU=dC9E2MO+iVbTAZag8sc1gimDy7iJ=q_ZA@mail.gmail.com"
type="cite">
<div dir="auto">
<div dir="auto"><span style="font-family:sans-serif">I'll submit
patch v7 as soon as possible.</span></div>
<div dir="auto"><span style="font-family:sans-serif">Thanks for
reviewing!</span></div>
<div dir="auto"><span style="font-family:sans-serif"><br>
</span></div>
<div dir="auto"><span style="font-family:sans-serif">Regards,</span></div>
<div dir="auto"><span style="font-family:sans-serif">KimJeongYeon</span></div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>