<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-04-21 14:12 GMT+09:00 Georg Chini <span dir="ltr"><<a href="mailto:georg@chini.tk" target="_blank">georg@chini.tk</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<div class="m_3955743200945054211moz-cite-prefix">On 21.04.2017 00:38, KimJeongYeon
wrote:<br>
</div>
</span><blockquote type="cite">
<div dir="auto"><span class="">
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017. 4. 21. 오전 3:28에 "Georg Chini"
<<a href="mailto:georg@chini.tk" target="_blank">georg@chini.tk</a>>님이
작성:
<blockquote class="m_3955743200945054211quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Still found a few issues, but I think the next version
will be final.
<div class="m_3955743200945054211quoted-text"><br></div></blockquote></div></div></div>
</span><span class=""><div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="m_3955743200945054211quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="m_3955743200945054211quoted-text">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+<br>
+ trigger_housekeeping(u);<br>
+ return PA_HOOK_OK; /* goto done; */<br>
</blockquote>
<br>
</div>
You forget to free module_name. I would move the "done"
label before the<br>
"if (done_something)" and do "done_something=true; goto
done" here.</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div dir="auto" style="font-family:sans-serif">Sorry. It was
my mistake while doing my local merging. 'goto done;' is
correct.</div>
</div>
</span></div>
</blockquote>
<br>
Still I would not call trigger_housekeeping() here but instead move
the "done" label.<br>
But I don't mind if you prefer it otherwise.<span class=""><br>
<br></span></div></blockquote><div><br></div><div>Your suggestions are good for me.</div><div>I've submitted patch v7 just ago. </div><div><br></div><div>Regards,</div><div>KimJeongYeon</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><span class="">
</span></div></blockquote></div><br></div></div>