<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 13.07.19 14:03, Georg Chini wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5eb1423d-a9a6-31ee-3b2f-3c3a981e3799@chini.tk">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">On 13.07.19 14:00, Georg Chini wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c86dd0b0-25c0-62c3-4369-9fd727259192@chini.tk">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<div class="moz-cite-prefix">On 28.05.19 18:18, Tanu Kaskinen
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5ced5f5cba42a_b6ab23ff1a98054dc77375c@gitlab-prod-gitlab-96769666b-7cn6k.mail">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<title> GitLab </title>
<style>img {
max-width: 100%; height: auto;
}
</style>
<div class="content">
<h3> Tanu Kaskinen pushed to branch master at <a
href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio"
moz-do-not-send="true">PulseAudio / pulseaudio</a> </h3>
<h4> Commits: </h4>
<ul>
<li> <strong><a
href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b"
moz-do-not-send="true">fd9e3452</a></strong>
<div> <span>by Felipe Sateler</span> <i>at
2019-05-28T16:16:49Z</i> </div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">i18n: Don't compile with -ffast-math
This flag results in calls to (at least) isfinite() and isnan() becoming
skipped, and a constant false returned. This caused volume-test to fail
on Debian: <a class="moz-txt-link-freetext" href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916504" moz-do-not-send="true">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916504</a>
Since PulseAudio deals with negative infinities with volume dB values,
this is not a problem only in volume-test. We shouldn't use -ffast-math
at all.
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats"> <a
href="#87db583be5c13c1f7b3c958b10e03d67b6a2ca06"
moz-do-not-send="true"> configure.ac </a> </li>
</ul>
<h4>Changes:</h4>
<li id="87db583be5c13c1f7b3c958b10e03d67b6a2ca06"> <a
href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b#87db583be5c13c1f7b3c958b10e03d67b6a2ca06"
moz-do-not-send="true"><strong>configure.ac</strong></a>
<hr>
<table class="code white" style="font-family: monospace;
font-size: 90%;" width="100%" cellspacing="0"
cellpadding="0" bgcolor="#fff">
<tbody>
<tr class="line_holder match" id=""
style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line"
data-linenumber="175" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right">...</td>
<td class="diff-line-num unfold js-unfold new_line"
data-linenumber="175" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right">...</td>
<td class="line_content match " style="padding-left:
0.5em; padding-right: 0.5em; color:
rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -175,7
+175,7 @@ AX_CHECK_COMPILE_FLAG([-std=gnu11],</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="175" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 175 </td>
<td class="diff-line-num new_line"
data-linenumber="175" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 175 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC175" class="line" lang="plaintext"> [-pedantic -Werror])</span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="176" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 176 </td>
<td class="diff-line-num new_line"
data-linenumber="176" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 176 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC176" class="line" lang="plaintext"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="177" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 177 </td>
<td class="diff-line-num new_line"
data-linenumber="177" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 177 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC177" class="line" lang="plaintext">AX_APPEND_COMPILE_FLAGS(</span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height:
1.6;">
<td class="diff-line-num old old_line"
data-linenumber="178" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style:
solid; padding: 0 5px;" bgcolor="#f9d7dc"
align="right"> 178 </td>
<td class="diff-line-num new_line old"
data-linenumber="178" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style:
solid; padding: 0 5px;" bgcolor="#f9d7dc"
align="right"> <br>
</td>
<td class="line_content old" style="padding-left:
0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC178" class="line" lang="plaintext"> [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -f<span class="idiff left right">fast-math -f</span>no-common -fdiagnostics-show-option -fdiagnostics-color=auto],</span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height:
1.6;">
<td class="diff-line-num new old_line"
data-linenumber="179" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style:
solid; padding: 0 5px;" bgcolor="#ddfbe6"
align="right"> <br>
</td>
<td class="diff-line-num new new_line"
data-linenumber="178" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style:
solid; padding: 0 5px;" bgcolor="#ddfbe6"
align="right"> 178 </td>
<td class="line_content new" style="padding-left:
0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC178" class="line" lang="plaintext"> [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -fno-common -fdiagnostics-show-option -fdiagnostics-color=auto],</span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="179" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 179 </td>
<td class="diff-line-num new_line"
data-linenumber="179" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 179 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC179" class="line" lang="plaintext"> [], [-pedantic -Werror])</span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="180" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 180 </td>
<td class="diff-line-num new_line"
data-linenumber="180" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 180 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC180" class="line" lang="plaintext"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height:
1.6;">
<td class="diff-line-num old_line"
data-linenumber="181" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 181 </td>
<td class="diff-line-num new_line"
data-linenumber="181" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #f0f0f0; border-right-style:
solid; padding: 0 5px;" bgcolor="#fafafa"
align="right"> 181 </td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC181" class="line" lang="plaintext">AS_CASE([" $CFLAGS "], [*" -O0 "*], [], [</span>
</pre>
</td>
</tr>
</tbody>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;"> — <br>
<a
href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b"
moz-do-not-send="true">View it on GitLab</a>. <br>
You're receiving this email because of your account on
gitlab.freedesktop.org. If you'd like to receive fewer
emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b"}}</script>
</p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
pulseaudio-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:pulseaudio-commits@lists.freedesktop.org" moz-do-not-send="true">pulseaudio-commits@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits</a></pre>
</blockquote>
<p>This patch breaks the use of the soxr resampler for me.<br>
PA crashes under certain conditions. I only tested after<br>
applying !120. (Before this patch set, the soxr resampler<br>
behaves quite strange anyway).<br>
</p>
<p>I think PA kicks me out because the real-time limit is<br>
exceeded and the limit is exceeded because the resampler<br>
is compiled without -ffast-math<br>
</p>
</blockquote>
</blockquote>
Further investigation shows that it does not affect current master.<br>
The problem starts with patch 2 of !120, which changes the soxr<br>
resampler to variable rate. The reason why the crash happens is<br>
totally unclear.<br>
</body>
</html>