[Slirp] [PATCH] slirp: ncsi: compute checksum for valid data length

Philippe Mathieu-Daudé philmd at redhat.com
Mon Dec 30 09:19:32 UTC 2019


On 12/30/19 10:09 AM, Samuel Thibault wrote:
> Philippe Mathieu-Daudé, le lun. 30 déc. 2019 10:06:22 +0100, a ecrit:
>> On 12/30/19 9:50 AM, Samuel Thibault wrote:
>>> Philippe Mathieu-Daudé, le lun. 30 déc. 2019 08:59:41 +0100, a ecrit:
>>>> last time I sent something the maintainers told me they prefer a
>>>> GitLab merge request, I didn't insisted and my patch got lost.
>>>
>>> Personally, I'm fine with either, I'm getting a mail in the same place
>>> in both cases. Sometimes it's better to discuss on the list, sometimes
>>> it's better to discuss on a merge request.
>>>
>>> In your case, I had assumed that Marc-André had applied your patch, so
>>> I had archived your mail. I have now applied it as well.
>>
>> Thanks! Unfortunately the commit description is mis-indented,
> 
> ?

Oh, apparently this is GitLab rendering weirdly:
https://gitlab.freedesktop.org/slirp/libslirp/commit/0c9adc39

> 
>> I suppose due to copy/pasting.
> 
> No, I git-am-ed the mail.

Good to know! Too bad this doesn't collect the commonly used git tags 
(Reviewed-by/Tested-by) which has helpful for downstream distributions.



More information about the Slirp mailing list