[Slirp] [PATCH] slirp: tftp: restrict relative path access

Samuel Thibault samuel.thibault at ens-lyon.org
Sun Jan 12 20:37:49 UTC 2020


Philippe Mathieu-Daudé, le jeu. 02 janv. 2020 12:55:22 +0100, a ecrit:
> On 1/2/20 10:28 AM, Marc-André Lureau wrote:
> > Please divide the rule for #ifdef G_OS_WIN32 .. #else ..
> 
> I'm confused here, req_fname[] is client-controlled, right?
> I'm seeing it filled in tftp_input():
> struct tftp_t *tp = (struct tftp_t *)m->m_data;
> So the path separator used differs from the client, not the server... Does
> it makes sense to handle this differently regarding the server OS?

AIUI the client has to request something that the server will
understand. The path is actually used on the server side here anyway.

Samuel


More information about the Slirp mailing list