[Slirp] [PATCH 0/6] snprintf() vulnerabilities

[Marc-André Lureau]

Hi

On Mon, Jan 27, 2020 at 4:36 PM Philippe Mathieu-Daudé
<philmd at redhat.com> wrote:
>
> Cc'ing Daniel, David and Laszlo who I Cc'ed in patch #1/6.
>
> On 1/27/20 10:24 AM, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > Various calls to snprintf() in libslirp assume that snprintf() returns
> > "only" the number of bytes written (excluding terminating NUL).
> >
> > Reported-by: Laszlo Ersek <lersek at redhat.com>
> >
> > Marc-André Lureau (6):
> >    util: add slirp_fmt() helpers
> >    dhcpv6: use slirp_fmt()
> >    misc: use slirp_fmt0()
> >    tftp: use slirp_fmt0()
> >    tcp_ctl: use slirp_fmt()
> >    tcp_emu: fix unsafe snprintf() usages
> >
> >   src/dhcpv6.c   | 13 +++++------
> >   src/misc.c     | 12 +++++-----
> >   src/tcp_subr.c | 49 +++++++++++++++++++--------------------
> >   src/tftp.c     |  8 ++-----
> >   src/util.c     | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >   src/util.h     |  3 +++
> >   6 files changed, 102 insertions(+), 45 deletions(-)
> >
>
> Note to the reviewers, this series is already applied to libslirp/master
> so changes requested will have to be as new patches op top.

Yes, I mainly sent the series on the ML as PJP asked me, it went
already through some iterations in a gitlab issue with Samuel.

> Is it possible to have GitLab send a notification to the list when a
> series is merged? That would save reviewers some time.

I don't know gitlab that well, but I have enabled "email-on-push"
service, let's see if that works.