[Bug 44570] New: Not waiting for cached images that haven't been added to the cache yet

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44570

             Bug #: 44570
           Summary: Not waiting for cached images that haven't been added
                    to the cache yet
    Classification: Unclassified
           Product: Spice
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gtk-client
        AssignedTo: spice-bugs at lists.freedesktop.org
        ReportedBy: yhalperi at redhat.com


The images cache is shared among all the display channels (one channel per
monitor). When there is more than one display channel, it is possible that
display channel X will get a reference to a cached image M, that should be
added to the cache by display channel Y. In the client side, display channel X
might receive this reference before Y added M. Thus, if M is not found in the
cache, X should wait for it.

In addition, the cache doesn't store the property of lossy/lossless for the
images and does not assure the image is lossless when receiving
SPICE_IMAGE_TYPE_FROM_CACHE_LOSSLESS. see channel-display.image_put_lossy,
channel-display.image_replace_lossy and channel-display.image_get_lossless.
If an image in the cache is lossy, channel-display.image_get_lossless should
wait till it is replaced with a lossless image.

Fixing this bug, together with the fix for bug 44179 should solve error msgs
like: 
(../common/canvas_base.c:1157) canvas_get_image_internal: condition surface !=
NULL failed
(../common/canvas_base.c:2208) canvas_draw_copy: condition src_image != NULL
failed

which occur when working with more than one monitor.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.