[Bug 44570] Not waiting for cached images that haven't been added to the cache yet

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 12 00:32:05 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=44570

--- Comment #9 from Yonit Halperin <yhalperi at redhat.com> 2012-01-12 00:32:05 PST ---
Comment on attachment 55344
  --> https://bugs.freedesktop.org/attachment.cgi?id=55344
Create a GCoroutine, get rid of wait_queue

Review of attachment 55344:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=44570&attachment=55344)
-----------------------------------------------------------------

Ack + small comments

::: gtk/gio-coroutine.c
@@ +64,2 @@
>      g_return_val_if_fail(sock != NULL, 0);
>  

add g_return_val_if_fail(&self->coroutine == coroutine_self) ?

@@ +80,4 @@
>          return *ret;
>  }
>  
> +void g_io_wakeup(GCoroutine *self)

"self" is a bit confusing here

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the spice-bugs mailing list