[Bug 44570] Not waiting for cached images that haven't been added to the cache yet

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 12 03:57:47 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=44570

--- Comment #13 from Marc-Andre Lureau <marcandre.lureau at gmail.com> 2012-01-12 03:57:47 PST ---
Comment on attachment 55344
  --> https://bugs.freedesktop.org/attachment.cgi?id=55344
Create a GCoroutine, get rid of wait_queue

Review of attachment 55344:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=44570&attachment=55344)
-----------------------------------------------------------------

::: gtk/gio-coroutine.c
@@ +64,2 @@
>      g_return_val_if_fail(sock != NULL, 0);
>  

I think it's a sane assumption. I just thought that technically there is no
limitation in managing/scheduling another coroutine, if you know what you are
doing...

@@ +80,4 @@
>          return *ret;
>  }
>  
> +void g_io_wakeup(GCoroutine *self)

In the header, we prefer using the name of the object (coroutine here), as
"self" is more an implementation detail for current object. "self" doesn't
really exist outside of the method.

that's more by convention..

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the spice-bugs mailing list