[Bug 55726] spice-server wrongly disconnects client

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55726

--- Comment #3 from Hans de Goede <jwrdegoede at fedoraproject.org> ---
Hi,

(In reply to comment #2)
> Thinking about it a bit more, technically the client is doing something
> wrong - it's violating the token scheme. 

No it is not, it is perfectly possible for the client to have a token for the
agent channel. IE it has been a while since it has last send an agent message)
and to then decide to send an agent message, IE a clipboard related message. If
while this message is "in transit" the guest agent then goes away, the server
will send a message to the client to let it know the agent is gone, but as the
agent message is already zipping along the network, there is nothing the client
can do to stop that message from arriving! But since the server
is in "no agent" state it not only rejects the message because of the "ERROR:
channel refused to allocate buffer." error, it also *disconnects* the client as
if the client has done something wrong, but as explained there is nothing the
client can do here, so the disconnecting it is wrong!

> So this could possibly be something
> to fix in the client as well. To add a bit more data that I forgot, when
> I've hit this I was able to connect with a new spicec client and not have a
> disconnection, but not with a remote-viewer (or spicy) client. Clearly the
> former wasn't sending any agent messages, and the later was - I'll hazard to
> conclude the message being sent was the AgentMonitorsConfig one. Regardless
> either the server is not sending a tokens message (bug - it should always do
> that, agent or not), or the client is not tracking them correctly (bug).

This is not what I'm seeing, what I'm seeing is:
1) repeated guest agent opening / closing of the virtio serial port, caused by
using an agent which does not yet have this fix:
http://cgit.freedesktop.org/spice/linux/vd_agent/commit/?id=9a58d8ee70c13677a1b62a2c8af694829c7afec5

2) That triggering the race I described above (it could even be the agent hello
message which is triggering this).

After this has happened, simply re-connecting with remote-viewer works fine,
iow not the same as what you're seeing.

Regards,

Hans

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20121008/113cea32/attachment.html>