[Bug 91350] webdav: memory not been freed makes qemu crash

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91350

--- Comment #9 from Marc-Andre Lureau <marcandre.lureau at gmail.com> ---
(In reply to Victor Toso from comment #8)
> Thanks for taking a look on this,
> 
> (In reply to Marc-Andre Lureau from comment #7)
> > so the two massif profiles aren't that different. But the second one has a
> > weird peak spike, it seems this is the bad guy:
> > 
> > ->44.37% (239,139,529B) 0x4EAA766: spice_realloc (mem.c:123)
> > | ->44.37% (239,137,425B) 0x4E37B98: __spice_char_device_write_buffer_get
> > (char_device.c:544)
> > | | ->44.37% (239,137,069B) 0x4E8EAD7:
> > spicevmc_red_channel_alloc_msg_rcv_buf (spicevmc.c:326)
> > | | | ->44.37% (239,137,069B) 0x4E4D184: red_channel_client_receive
> > (red_channel.c:272)
> > 
> > 
> > 240M... it looks wrong :)
> 
> Well, the file has 327M :P

ok, but webdav channels uses max 64k messages iirc.

it's weird that webdav would have memory issues and not usbredir for ex

> 
> The __spice_char_device_write_buffer_get try to get a buffer from memory
> pool queue; If the queue is empty it creates another WriteBuffer and after
> the data is written to the guest, it insert the WriteBuffer to the memory
> pool queue again.
> 
> The WIP patches try to limit the memory pool max size to (10 * 65535 B) and
> it also free the memory pool queue when client disconnect.

ah..

> 
> But even after disconnection the memory is not freed on qemu process.

the pool may keep the memory, across reconnection, no?

> QEMU also does use a lot of memory on this write
> 
> ->49.64% (267,580,319B) 0x308B89: malloc_and_trace (vl.c:2724)
> | ->49.38% (266,167,561B) 0x67CE678: g_malloc (gmem.c:97)
> | | ->49.03% (264,241,152B) 0x511D8E: qemu_coroutine_new
> (coroutine-ucontext.c:106)
> | | | ->49.03% (264,241,152B) 0x510E24: qemu_coroutine_create
> (qemu-coroutine.c:74)
> (...)

weird, it's like qemu would create 256 coroutines, maybe it does :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20150820/f113f133/attachment.html>