[Bug 93249] key event going to display even with keyboard ungrabbed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93249

--- Comment #23 from Marc-Andre Lureau <marcandre.lureau at gmail.com> ---
(In reply to Zeeshan Ali from comment #22)
> (In reply to Marc-Andre Lureau from comment #21)
> > spice-gtk input behaviour is rather simple:
> > - has no focus -> no input
> > - has focus -> gtk input is handled by the widget
> 
> And this is normal for most widget which do not need the concept of
> 'keyboard grab'.

what does this have to do with 'keyboard grab'? there are 3 states here, and
you seem to agree they make sense. 

> 
> > - has focus + grab -> all keyboard input (including "system keys", except
> > vt-switch) is handled by the widget
> 
> That is fine too.
> 
> The issue here is has_focus + ungrabbed case. Like I said before, If user
> explicitly requested keyboard ungrab (and provided spice and/or App does
> make sure user knows keyboard in ungrabbed currently), all key events should
> really go to client/host and none to guest.

so you want 4th state (I wish you explained this a bit more clearly from the
start)

- after ungrab, the widget should take no input == loose the focus

Imho this does't make sense, how would you get back to the focus state? I
really this would be confusing for the user.

Anyway, you can experiment with this in Boxes, when the keyboard grab is lost,
you can just change the focus to another widget.

> > When the widget has the focus, there is no handling of focus chain built-in
> > the widget, but like any other accelerator, you can set one in your app.
> 
> I don't know what you mean. Boxes has accelerators for display state but
> they currently don't work even when keyboard is ungrabbed and that's the
> issue here.

It should work, it works with virt-viewer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20151209/8845be7e/attachment.html>