[Bug 93249] key event going to display even with keyboard ungrabbed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93249

--- Comment #37 from Marc-Andre Lureau <marcandre.lureau at gmail.com> ---
(In reply to Zeeshan Ali from comment #36)
> (In reply to Pavel Grunt from comment #35)
> > I think Marc-Andre mentioned it and made it clear. When you press the ungrab
> > combo the keys does not go to the guest, they go to the app which has the
> > focus.
> 
> Yes he did but I also pointed out that this rule is not so set in stone.
> Spice-gtk is a bit special:
> 
> 1. You normally want *all* keyboard events to go to guest. If you compare it
> to 99% of widgets out there, they don't eat all keyboard events even if they
> are focused.

99% is a bit over-estimated, all input widget allowing you to type is not 1%...

> 2. SpiceGtk already has this concept of keyboard-ungrab and I don't know of
> any gtk+ widget (except for vnc which is the same case) that has this
> concept. I'm not asking for a new state but rather extending the idea of
> this keyboard-ungrab to include all keys, as users would expect it to be,
> not just system keys.
> 
> Since users will be expecting that in all UIs, I strongly recommend this be
> solved by spice-gtk, rather than be done separately in every app that uses
> spice-gtk.

Imho it's tricky to change spice-gtk keyboard behaviour at this point without
breaking something, but perhaps something clever could be done, but it needs
careful thinking and testing. I would rather like to see that behaviour adopted
by a few apps before burring it in spice-gtk default behavour or API.

> > If you want to stop receiving the keys, just use the disable inputs
> > property [0], as Marc-Andre said in the comment 4.
> 
> That also disables mouse input and that's not at all what I want.

That's really broken to me. Having mouse input but no keyboard, I would
immediately wonder what is wrong with the VM and how to solve it.

> I looked into implementing it in Boxes yesterday and it's doable by
> switching focus to event_box that contains the SpiceGtk widget on keyboard
> ungrab and undoing that on receiving ungrab keys so it's not really a matter
> of "if Boxes can do it" but rather "Whether Boxes should do it".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20151211/e945f17c/attachment.html>