[Bug 92820] New: Spice-gtk crashes when using lz in 16bpp mode on Windows XP

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92820

            Bug ID: 92820
           Summary: Spice-gtk crashes when using lz in 16bpp mode on
                    Windows XP
           Product: Spice
           Version: unspecified
          Hardware: Other
                OS: Windows (All)
            Status: NEW
          Severity: major
          Priority: medium
         Component: spice-gtk
          Assignee: spice-bugs at lists.freedesktop.org
          Reporter: lvenhoda at redhat.com

All spice-gtk clients (virt-viewer, remote-viewer, spicy and virtmanager)
crash, when image compression is set to lz, and guest is set to 16bpp color
mode. This was tested on Windows XP.

How to reproduce:
1. Use Windows XP virtual machine.
2. Install QXL driver
3. Set image compression to lz
4. Connect to VM using virt-viewer
5. Set Color Quality to 16bpp
(Right click on the Desktop -> Properties -> Settings -> Color quality)

This issue can be "fixed", when we set lz decoding, to always decode 16bpp
image as 32bpp image. Thid could mean, that we send 16bpp image as 32bpp image.

This diff shows what change needs to be done, to "fix" this issue:

diff --git a/common/canvas_base.c b/common/canvas_base.c
index 6f48340..12b285e 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -848,8 +848,8 @@ static pixman_image_t *canvas_get_lz(CanvasBase *canvas,
SpiceImage *image,
             as_type = LZ_IMAGE_TYPE_RGB32;
             pixman_format = PIXMAN_x8r8g8b8;
         } else {
-            as_type = LZ_IMAGE_TYPE_RGB16;
-            pixman_format = PIXMAN_x1r5g5b5;
+            as_type = LZ_IMAGE_TYPE_RGB32;
+            pixman_format = PIXMAN_x8r8g8b8;
         }
         break;
     default:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20151104/45250f63/attachment.html>