<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - gstreamer nvh264enc deadlock and crashed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103417">103417</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>gstreamer nvh264enc deadlock and crashed
</td>
</tr>
<tr>
<th>Product</th>
<td>Spice
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>server
</td>
</tr>
<tr>
<th>Assignee</th>
<td>spice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>bochuan.ding@bridgetek.cn
</td>
</tr></table>
<p>
<div>
<pre>Spice server version 0.13.90
Host OS: Ubuntu 16.04
Guest OS: Windows 7
For hardware accelerate, I use GStreamer nvh264enc in place of xh264enc.
However, it often get deadlock when GStreamer get restarted. I debugged the
gstreamer plugin nvenc and I find the problem in the free_pipeline() and
create_pipeline()。 Because there is no mutex lock to protect the process
create/free pipeline，when the pipeline status switched in a short time,e.g
start -> stop -> start, the nvenc would be in unknown status. In my case, it
causes the deadlock inside the nvenc plugin.
I try to fix this bug in a simple way. In the configure_pipeline(), call
free_pipeline() before create_pipeline(). This will make sure that we do free
the resource of pipeline and it's safe even if the encoder->pipeline is NULL.
The source code is below. Here is the only way to call create_pipeline() except
the gstreamer_encoder_new(), but it's like a initialized constructor, so we
just take care about the configure_pipeline() which takes responsibility for
switching the status of the pipeline.
static gboolean configure_pipeline(SpiceGstEncoder *encoder)
{
if (!encoder->set_pipeline) {
return TRUE;
}
free_pipeline(encoder->pipeline);
if (!encoder->pipeline && !create_pipeline(encoder)) {
return FALSE;
}
...
}
I can't guarantee that it doesn't bring in other bugs. I think there should be
a more grace method to fix this problem.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>